Make Ask Loci toggle work outside the workspace - #5
Merged
Conversation
The toolbar button, option-command-I menu item, and command palette action post lociToggleNotebookInspector, whose only listener lives inside ChatWorkspaceView — a view that exists only while Ask Loci is already open, so the controls silently did nothing elsewhere. Listen at the shell level and enter the workspace the way the sidebar row does; inside Ask Loci the existing listener still toggles the chat panel. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChatWorkspaceView, which exists only while Ask Loci is already open — so the controls did nothing from the libraryTesting
swift build -c releasecleanswift test— 23/23 passing🤖 Generated with Claude Code